Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): use pd clock in storage sink #10351

Merged
merged 3 commits into from
Jan 22, 2024
Merged

sink(ticdc): use pd clock in storage sink #10351

merged 3 commits into from
Jan 22, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Dec 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10352, ref #10374

What is changed and how it works?

  • Use pdClock instead of local clock to generate date seperator.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Fix the issue that date seperator generated by the storage sink may roll back in table scheduling scenarios`.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 23, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@zhangjinpeng87
Copy link
Contributor

It is ok for me if this is a quick and short term fix. But for long term we eventually will decouple the dependency with PD, we should have a better comprehensive solution later.

@zhangjinpeng87 zhangjinpeng87 mentioned this pull request Dec 27, 2023
Open
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review January 10, 2024 03:33
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 10, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Jan 10, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 11, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

Merging #10351 (ca5ebb0) into master (3e9c9de) will decrease coverage by 5.4445%.
Report is 305 commits behind head on master.
The diff coverage is 55.1215%.

Additional details and impacted files
Components Coverage Δ
cdc 62.6388% <55.1215%> (-0.7681%) ⬇️
dm 51.3025% <ø> (∅)
engine 63.4423% <ø> (∅)
Flag Coverage Δ
unit 57.9624% <55.1215%> (-5.4445%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10351        +/-   ##
================================================
- Coverage   63.4069%   57.9624%   -5.4445%     
================================================
  Files           392        849       +457     
  Lines         51067     126896     +75829     
================================================
+ Hits          32380      73552     +41172     
- Misses        16385      47954     +31569     
- Partials       2302       5390      +3088

@CharlesCheung96
Copy link
Contributor Author

/retest

2 similar comments
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/retest

4 similar comments
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit c8ea7d0 into pingcap:master Jan 22, 2024
24 of 28 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 22, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10351
a406dbe 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10519.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10520.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 22, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10351
cefa9c5 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 22, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10351
1b9c26a 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10521.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
cff9687 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
89b4b6a 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
88b5469 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jan 24, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
525bb49 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 7, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
450c156 
close pingcap#10352, ref pingcap#10374
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 9, 2024
@CharlesCheung96
sink(ticdc): use pd clock in storage sink (pingcap#10351)
ca81e65 
close pingcap#10352, ref pingcap#10374
ti-chi-bot bot pushed a commit that referenced this pull request Feb 9, 2024
@ti-chi-bot
sink(ticdc): use pd clock in storage sink (#10351) (#10521)
67111b1 
close #10352, ref #10374
ti-chi-bot bot pushed a commit that referenced this pull request Feb 26, 2024
@ti-chi-bot
sink(ticdc): use pd clock in storage sink (#10351) (#10520)
223283c 
close #10352, ref #10374
ti-chi-bot bot pushed a commit that referenced this pull request Mar 28, 2024
@ti-chi-bot
sink(ticdc): use pd clock in storage sink (#10351) (#10519)
39759ab 
close #10352, ref #10374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@zhangjinpeng87 zhangjinpeng87 Awaiting requested review from zhangjinpeng87

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove the local clock dependency from storage sink
5 participants
@CharlesCheung96 @zhangjinpeng87 @ti-chi-bot @sdojjy @asddongmen